This commit is contained in:
Yanick Champoux 2022-08-26 15:30:03 -04:00
parent 3bb9221c27
commit 43702fe096
2 changed files with 30 additions and 23 deletions

View File

@ -3,7 +3,7 @@ import R from 'remeda';
import { action } from './actions.js';
function isActionGen(action) {
return typeof action === "function" && action.type;
return typeof action === 'function' && action.type;
}
export class Updux {
@ -18,18 +18,20 @@ export class Updux {
this.#localInitial = config.initial ?? {};
this.#subduxes = config.subduxes ?? {};
this.#actions = R.mapValues( config.actions ?? {}, (arg,name) =>
isActionGen(arg) ? arg : action(name,arg)
this.#actions = R.mapValues(config.actions ?? {}, (arg, name) =>
isActionGen(arg) ? arg : action(name, arg),
);
Object.entries(this.#subduxes).forEach(([slice, sub]) =>
this.#addSubduxActions(slice, sub),
);
Object.entries(this.#subduxes).forEach( ([slice,sub]) => this.#addSubduxActions(slice,sub) )
}
#addSubduxActions(_slice, subdux) {
if( ! subdux.actions ) return;
if (!subdux.actions) return;
// TODO action 'blah' defined multiple times: <where>
Object.entries( subdux.actions ).forEach( ([action,gen]) => {
if( this.#actions[action] ) {
if( this.#actions[action] === gen ) return;
Object.entries(subdux.actions).forEach(([action, gen]) => {
if (this.#actions[action]) {
if (this.#actions[action] === gen) return;
throw new Error(`action '${action}' already defined`);
}

View File

@ -53,29 +53,34 @@ test('subduxes actions', () => {
});
test('throw if double action', () => {
expect( () => new Updux({
actions: {
foo: action('foo'),
},
subduxes: {
beta: {
expect(
() =>
new Updux({
actions: {
foo: action('foo'),
},
},
},
}) ).toThrow(/action 'foo' already defined/);
subduxes: {
beta: {
actions: {
foo: action('foo'),
},
},
},
}),
).toThrow(/action 'foo' already defined/);
});
test('action definition shortcut', () => {
const foo = new Updux({
actions: {
foo: null,
bar: x => ({x}),
},}
);
bar: (x) => ({ x }),
},
});
expect( foo.actions.foo("hello") ).toEqual({ type: 'foo', payload: 'hello' });
expect( foo.actions.bar("hello") ).toEqual({ type: 'bar', payload: {x:'hello'} });
expect(foo.actions.foo('hello')).toEqual({ type: 'foo', payload: 'hello' });
expect(foo.actions.bar('hello')).toEqual({
type: 'bar',
payload: { x: 'hello' },
});
});